Change in osmo-pcu[master]: pcu_l1_if: ignore PDCH interference reports, do not log errors

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jun 21 16:33:23 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/24721 )

Change subject: pcu_l1_if: ignore PDCH interference reports, do not log errors
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/24721/1/src/pcu_l1_if.cpp 
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/24721/1/src/pcu_l1_if.cpp@996 
PS1, Line 996: 		/* TODO: handle interference reports */
> You could so far simpli call a function and print them?
You mean introducing a function that would print the reports? I don't really see the need for spamming logs with interference reports every ~1 second. IMO, storing them somewhere and adding a VTY command makes more sense. In any case, I just want to suspend frequent "Received unknown PCU msg type" messages.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24721
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I88e5c53131ee94bc3f3ff3f095077feb4ff272a7
Gerrit-Change-Number: 24721
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Jun 2021 16:33:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210621/e8051eea/attachment.htm>


More information about the gerrit-log mailing list