Change in osmo-ttcn3-hacks[master]: bsc: f_cipher_mode(): verify enc alg in Cipher Mode Complete msg

laforge gerrit-no-reply at lists.osmocom.org
Mon Jun 21 16:26:10 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24671 )

Change subject: bsc: f_cipher_mode(): verify enc alg in Cipher Mode Complete msg
......................................................................

bsc: f_cipher_mode(): verify enc alg in Cipher Mode Complete msg

Related: SYS#5324
Change-Id: I88b386c55e23cc180131e95a005d08cbc3ec102b
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 0d46bc6..12712db 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -758,11 +758,13 @@
 		repeat;
 		}
 	[] BSSAP.receive(tr_BSSMAP_CipherModeCompl) -> value bssap {
-		// bssap.bssmap.cipherModeComplete.chosenEncryptionAlgorithm.algoritmhIdentifier
 		if (exp_fail == true) {
 			Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected Cipher Mode Complete");
 		} else {
 			setverdict(pass);
+			if (oct2int(bssap.pdu.bssmap.cipherModeComplete.chosenEncryptionAlgorithm.algorithmIdentifier) != enum2int(alg_rsl)) {
+				setverdict(fail, "Unexpected Encryption Algorithm ID in BSSMAP Cipher Mode Complete");
+			}
 		}
 		}
 	[] BSSAP.receive(tr_BSSMAP_CipherModeRej) -> value bssap {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24671
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I88b386c55e23cc180131e95a005d08cbc3ec102b
Gerrit-Change-Number: 24671
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210621/8131a7b3/attachment.htm>


More information about the gerrit-log mailing list