Change in osmo-bts[master]: Report interference levels in RSL RF RESource INDication

pespin gerrit-no-reply at lists.osmocom.org
Mon Jun 21 16:09:10 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24612 )

Change subject: Report interference levels in RSL RF RESource INDication
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/24612/1/src/common/gsm_data.c 
File src/common/gsm_data.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24612/1/src/common/gsm_data.c@316 
PS1, Line 316: 	meas_avg = meas_sum / meas_num;
> What's wrong with that abs()? What do we win if I do it once?
What's wrong with doing it only once at the end?
Doing it once at the end:
1- It's clearer from mathematical point of view
2- less operations are performed.

Anyway, +1 since I don't want to block this and you/others seem to be fine with current approach.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24612
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id80fdbef087de625149755165c025c0a9563dc85
Gerrit-Change-Number: 24612
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Jun 2021 16:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210621/418a3fde/attachment.htm>


More information about the gerrit-log mailing list