This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24712 ) Change subject: scheduler: unset TRX_CHAN_FLAG_AUTO_ACTIVE for TRXC_IDLE ...................................................................... Patch Set 2: > Patch Set 2: > > why d oes it not make sense? Is it because in osmo-trx (on C0) we're sending dummy bursts in downlink if there's no data from osmo-bts for an inactive channel? > > What about 3rd party TRX implementations, do we know the implications? My commit message is a bit confusing, sorry. In the current implementation, we pre-initialize the Downlink burst buffers for C0 with dummy burst bits in bts_sched_init_buffers(). This simplifies the scheduling: if there is a normal burst for C0, it overwrites dummy burst bits in the buffer; otherwise we send dummy burst. This also eliminates the need to have a logical channel handler for TRXC_IDLE (previous commit) and the need to have this 'auto-active' flag. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifade0eab0605154196322ff20b1b3a44495f8a2e Gerrit-Change-Number: 24712 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 21 Jun 2021 15:57:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210621/edbbe9d8/attachment.htm>