Change in osmo-bts[master]: oml: fix handling of NM_ATT_INTERF_BOUND attribute

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jun 21 15:47:54 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24706 )

Change subject: oml: fix handling of NM_ATT_INTERF_BOUND attribute
......................................................................

oml: fix handling of NM_ATT_INTERF_BOUND attribute

Looks like this part of the code has never been tested.  The old
code would dereference the same value in the loop and assign it
to all members in array 'bts->interference.boundary'.

Change-Id: I7f83d8e6eb6cc19e3e9529ba06617a902de23e35
Related: SYS#5313, OS#1569
---
M src/common/oml.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Hoernchen: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/common/oml.c b/src/common/oml.c
index 8b84f85..aeded8b 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -586,7 +586,7 @@
 	if (TLVP_PRES_LEN(&tp, NM_ATT_INTERF_BOUND, 6)) {
 		payload = TLVP_VAL(&tp, NM_ATT_INTERF_BOUND);
 		for (i = 0; i < 6; i++) {
-			int16_t boundary = *payload;
+			const int16_t boundary = payload[i];
 			bts->interference.boundary[i] = -1 * boundary;
 		}
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24706
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7f83d8e6eb6cc19e3e9529ba06617a902de23e35
Gerrit-Change-Number: 24706
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210621/0fd437d7/attachment.htm>


More information about the gerrit-log mailing list