Change in osmo-bts[master]: main: do not use fprintf to log fatal errors

dexter gerrit-no-reply at lists.osmocom.org
Mon Jun 21 14:59:39 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24707 )

Change subject: main: do not use fprintf to log fatal errors
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24707/1/src/common/main.c 
File src/common/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24707/1/src/common/main.c@95 
PS1, Line 95: 			LOGP(DLGLOBAL, LOGL_FATAL, "%s: Unknown VTY reference generation "
> I agree, we cannot use logging here.
Done


https://gerrit.osmocom.org/c/osmo-bts/+/24707/1/src/common/main.c@306 
PS1, Line 306: 		LOGP(DLGLOBAL, LOGL_FATAL, "Failed to create BTS structure\n");
> what is more realistic in production deployments is e.g. the use of syslog target. […]
Is the support for async logging already merged? At least from what I can see when I do tests the error messages are displayed even though the main loop is not reached.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24707
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2ae4acf6a92137236e1b62c2d0aab79a34134f45
Gerrit-Change-Number: 24707
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Jun 2021 14:59:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210621/5fad73e9/attachment.htm>


More information about the gerrit-log mailing list