Change in osmo-ttcn3-hacks[master]: bsc: reduce args to f_cipher_mode()

neels gerrit-no-reply at lists.osmocom.org
Sun Jun 20 20:57:34 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24668 )

Change subject: bsc: reduce args to f_cipher_mode()
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24668/2/bsc/MSC_ConnectionHandler.ttcn 
File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24668/2/bsc/MSC_ConnectionHandler.ttcn@722 
PS2, Line 722: isvalue
> Looks like you need ispresent() here?
that was there before my patch, are you sure i should change it?
if we do, it should probably a separate patch (that need not be submitted by me, hint hint)


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24668/2/bsc/MSC_ConnectionHandler.ttcn@723 
PS2, Line 723: valueof
> There is no need to use valueof() here.
same



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24668
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2cb8282e55436da5ae64ab569df87d5d5a0dd2f0
Gerrit-Change-Number: 24668
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sun, 20 Jun 2021 20:57:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210620/28b08ebb/attachment.htm>


More information about the gerrit-log mailing list