Change in osmo-ttcn3-hacks[master]: bsc: replace TC_assignment_fr_a5_4 with TC_assignment_fr_a5_not_sup

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jun 19 10:52:50 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24667 )

Change subject: bsc: replace TC_assignment_fr_a5_4 with TC_assignment_fr_a5_not_sup
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24667/2/bsc/BSC_Tests.ttcn 
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24667/2/bsc/BSC_Tests.ttcn@3420 
PS2, Line 3420: var PDU_BSSAP ass_tpl
I find this confusing that a regular (not template) variable has '_tpl' in its name.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24667/2/bsc/BSC_Tests.ttcn@3430 
PS2, Line 3430: valueof
Are you sure valueof() is actually needed here?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24667/2/bsc/BSC_Tests.ttcn@3439 
PS2, Line 3439: codecList
It would probably be good to accept this as an optional parameter in tr_BSSMAP_ComplL3(), so you would have:

  [not g_pars.aoip] BSSAP.receive(tr_BSSMAP_ComplL3(codecList := omit));
  [g_pars.aoip] BSSAP.receive(tr_BSSMAP_ComplL3(codecList := ?));



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24667
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I83eca18d1b3d8d58177aa3750935ec5a3a985ca4
Gerrit-Change-Number: 24667
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 19 Jun 2021 10:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210619/749f3cde/attachment.htm>


More information about the gerrit-log mailing list