Change in osmo-ttcn3-hacks[master]: bsc: f_cipher_mode(): fail quicker on key mismatch

neels gerrit-no-reply at lists.osmocom.org
Fri Jun 18 21:46:21 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24670 )

Change subject: bsc: f_cipher_mode(): fail quicker on key mismatch
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24670/1/bsc/MSC_ConnectionHandler.ttcn 
File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24670/1/bsc/MSC_ConnectionHandler.ttcn@734 
PS1, Line 734: 		expect_kc := ''O;
> I don't know the details in the tests, but as I staed in the other comment, the UE and BSC will stor […]
i noticed that i somehow inadvertently *created* the ''O case in the first place, so far osmo-bsc was always sending the key also for A5/0 and the test was always expecting the actual Kc also for A5/0. Placed some comments now to explain.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24670
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia79779f4229da4a5af271235a5e82c6fd59ea3a2
Gerrit-Change-Number: 24670
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Jun 2021 21:46:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210618/c808e12f/attachment.htm>


More information about the gerrit-log mailing list