Change in osmo-bts[master]: osmo-bts-trx: print timeslot brief info in 'show transceiver'

pespin gerrit-no-reply at lists.osmocom.org
Fri Jun 18 10:21:02 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24714 )

Change subject: osmo-bts-trx: print timeslot brief info in 'show transceiver'
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24714/1/src/osmo-bts-trx/trx_vty.c 
File src/osmo-bts-trx/trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24714/1/src/osmo-bts-trx/trx_vty.c@90 
PS1, Line 90: 			vty_out(vty, " bisc   : undefined%s", VTY_NEWLINE);
remark: typo here i nbsic, can you submit a patch on top of your patchset?


https://gerrit.osmocom.org/c/osmo-bts/+/24714/1/src/osmo-bts-trx/trx_vty.c@99 
PS1, Line 99: 			vty_out(vty, "  timeslot #%u (%s)%s",
I'm not really sure this kind of info is revelant when doing show transceiver. What about a "show timeslot <trx_nr> <ts_nr>" or alike?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24714
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ibe624e4b801cae2dc00feb99441b7d606005b846
Gerrit-Change-Number: 24714
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Jun 2021 10:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210618/9e7ff5c2/attachment.htm>


More information about the gerrit-log mailing list