Change in osmo-trx[master]: vty: printing fn offset should be signed

Hoernchen gerrit-no-reply at lists.osmocom.org
Thu Jun 17 20:29:58 UTC 2021


Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/24696 )

Change subject: vty: printing fn offset should be signed
......................................................................

vty: printing fn offset should be signed

...because it is usually negative

Change-Id: I8297dbb0fec25720e73d59fd8e38834029154405
---
M CommonLibs/trx_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index 30f55c8..2b0ba71 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -639,7 +639,7 @@
 	if (trx->cfg.stack_size != 0)
 		vty_out(vty, " stack-size %u%s", trx->cfg.stack_size, VTY_NEWLINE);
 	if (trx->cfg.ul_fn_offset != 0)
-		vty_out(vty, " ul-fn-offset %u%s", trx->cfg.ul_fn_offset, VTY_NEWLINE);
+		vty_out(vty, " ul-fn-offset %d%s", trx->cfg.ul_fn_offset, VTY_NEWLINE);
 	trx_rate_ctr_threshold_write_config(vty, " ");
 
 	for (i = 0; i < trx->cfg.num_chans; i++) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/24696
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8297dbb0fec25720e73d59fd8e38834029154405
Gerrit-Change-Number: 24696
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210617/a24a26af/attachment.htm>


More information about the gerrit-log mailing list