Change in libosmocore[master]: vty: make function cmd_range_match() public

dexter gerrit-no-reply at lists.osmocom.org
Thu Jun 17 08:26:45 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24691 )

Change subject: vty: make function cmd_range_match() public
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24691/1/include/osmocom/vty/command.h 
File include/osmocom/vty/command.h:

https://gerrit.osmocom.org/c/libosmocore/+/24691/1/include/osmocom/vty/command.h@486 
PS1, Line 486: int cmd_range_match(const char *range, const char *str);
> Let's add a proper prefix for it: vty_cmd_range_match, or osmo_cmd_range_match. […]
Its more like i want to use it with libosmoctrl. I call this function from osmo-bsc. I think its ok to have it in libosmovty. Its probably unlikely that we will have some program that uses libosmoctrl but not libosmovty...



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24691
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I53fc207677f52b1dc748b01d58424839cdba807c
Gerrit-Change-Number: 24691
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Jun 2021 08:26:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210617/0a1284ed/attachment.htm>


More information about the gerrit-log mailing list