Change in osmo-sgsn[master]: add support for multiple encryption algorithms and a5/4

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 16 14:29:19 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/24304 )

Change subject: add support for multiple encryption algorithms and a5/4
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/6/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/6/src/sgsn/gprs_gmm.c@448 
PS6, Line 448:  {
coding style


https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/6/src/sgsn/gprs_llc.c 
File src/sgsn/gprs_llc.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/6/src/sgsn/gprs_llc.c@718 
PS6, Line 718: 
unrelated ws


https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/6/src/sgsn/sgsn_vty.c 
File src/sgsn/sgsn_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/6/src/sgsn/sgsn_vty.c@771 
PS6, Line 771: ){
coding style


https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/6/src/sgsn/sgsn_vty.c@772 
PS6, Line 772: ){
same here



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/24304
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie6700c4e9d2df1eb5fde1b971e287b62668cc2de
Gerrit-Change-Number: 24304
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jun 2021 14:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210616/6df83a14/attachment.htm>


More information about the gerrit-log mailing list