Change in osmocom-bb[master]: trxcon/scheduler: cosmetic: move TDMA frame number calculation

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 16 13:57:38 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24660 )

Change subject: trxcon/scheduler: cosmetic: move TDMA frame number calculation
......................................................................

trxcon/scheduler: cosmetic: move TDMA frame number calculation

Change-Id: I79efdfa543d37889dc6749eb25aab4e1639749c6
---
M src/host/trxcon/sched_trx.c
1 file changed, 5 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/host/trxcon/sched_trx.c b/src/host/trxcon/sched_trx.c
index 0025e0c..91310c0 100644
--- a/src/host/trxcon/sched_trx.c
+++ b/src/host/trxcon/sched_trx.c
@@ -50,9 +50,13 @@
 	enum trx_lchan_type chan;
 	uint8_t offset, bid;
 	struct trx_ts *ts;
-	uint32_t fn;
 	int i;
 
+	/* Advance TDMA frame number in order to give the transceiver
+	 * more time to handle the burst before the actual transmission. */
+	const uint32_t fn = GSM_TDMA_FN_SUM(sched->fn_counter_proc,
+					    sched->fn_counter_advance);
+
 	/* Iterate over timeslot list */
 	for (i = 0; i < TRX_TS_COUNT; i++) {
 		/* Timeslot is not allocated */
@@ -64,12 +68,6 @@
 		if (ts->mf_layout == NULL)
 			continue;
 
-		/**
-		 * Advance frame number, giving the transceiver more
-		 * time until a burst must be transmitted...
-		 */
-		fn = GSM_TDMA_FN_SUM(sched->fn_counter_proc, sched->fn_counter_advance);
-
 		/* Get frame from multiframe */
 		offset = fn % ts->mf_layout->period;
 		frame = ts->mf_layout->frames + offset;

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24660
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I79efdfa543d37889dc6749eb25aab4e1639749c6
Gerrit-Change-Number: 24660
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210616/576b73f7/attachment.htm>


More information about the gerrit-log mailing list