Change in osmo-bsc[master]: handover_ctrl: add control interface for handover settings

dexter gerrit-no-reply at lists.osmocom.org
Wed Jun 16 12:55:38 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24600 )

Change subject: handover_ctrl: add control interface for handover settings
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/doc/manuals/chapters/control.adoc 
File doc/manuals/chapters/control.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/doc/manuals/chapters/control.adoc@41 
PS1, Line 41: |handover_ho_active|RW|No|"0","1","default"|Enable/disable handover.
> I did not notice that. This probably means that I have dig a bit deeper. […]
This is now also fixed. It was not easy as well since the control interface seems to have a lot of quirks (and maybe bugs). I do not see through entirely, but by design it seems not to be possible to install a command twice on different nodes. Also there seems to be no way to find on which nodes we are. The node variable is a void pointer to the struct we are working on. (e.g. bts) but we have no way to check if we are really on the BTS node. We just have to trust that cmd->node contains what we expect.


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c 
File src/osmo-bsc/handover_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@80 
PS1, Line 80: CTRL_CMD_DEFINE(NAME, "handover_"#NAME); \
> The vty command name is in VTY_CMD; […]
I have thought through both. Option 1 is a bit problematic as we have VTY commands that have spaces (which become to dots) and - characters in them. We can not use - in the C code. Also I think it would be a mess to replace all the struct members.

Adding another argument to the macro is the better solution I think. Ironically it turned out (I did not know that before) that the control interface commands must have spaces where later the dots are expected. So we can just use VTY_CMD_PREFIX and VTY_CMD directly and we get exactly what we need. Unfortunately there are min-free-slots tch/f and min-free-slots tch/h. The / is a forbidden character in the control interface. So we still need the additional argument to define a string without /. At least I managed to make the new parameter (CTRL_CMD) optional.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24600
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12f143906818fd6b16e8783157cbb1eb51e49ffc
Gerrit-Change-Number: 24600
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jun 2021 12:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210616/9f3171a9/attachment.htm>


More information about the gerrit-log mailing list