Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 16 12:44:13 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24659 )

Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/24659/1/src/target/trx_toolkit/transceiver.py 
File src/target/trx_toolkit/transceiver.py:

https://gerrit.osmocom.org/c/osmocom-bb/+/24659/1/src/target/trx_toolkit/transceiver.py@275 
PS1, Line 275: 			return None
> shouldn't you convert this to a NOPE. […]
In this function we do not transform from Tx to Rx, we just receive and parse PDUs.
NOPE.ind flag will be set during the actual transformation in TxMsg.trans().



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809
Gerrit-Change-Number: 24659
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jun 2021 12:44:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210616/5cb6f055/attachment.htm>


More information about the gerrit-log mailing list