Change in pysim[master]: card_handler: clean-up

dexter gerrit-no-reply at lists.osmocom.org
Wed Jun 16 11:32:02 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23595 )

Change subject: card_handler: clean-up
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23595/2/pySim/card_handler.py 
File pySim/card_handler.py:

https://gerrit.osmocom.org/c/pysim/+/23595/2/pySim/card_handler.py@34 
PS2, Line 34: Abstract
> Let's please use Python's API for abstract classes: https://docs.python.org/3/library/abc.html.
I do not think that this is a mandatory requirement. I agree it would be good to use the python API, but lets not get this blocked by this since it is more or less a cosmetic thing.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23595
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7168506cbebb1ebb67f47453419b860824912051
Gerrit-Change-Number: 23595
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Jun 2021 11:32:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210616/bc89868a/attachment.htm>


More information about the gerrit-log mailing list