This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24665 ) Change subject: bsc: Fix race condition exiting f_ho_out_of_this_bsc ...................................................................... bsc: Fix race condition exiting f_ho_out_of_this_bsc The function didn't wait to receive the 2 messages from the BSC. As a result, they may have arrived while tearing down the test components shortly after exiting the function and provoke a Dynamic Test Error while pushing the messages up the stack since some of the stack layers may already be unavailable. Test TC_ho_out_of_this_bsc() workarounded this by using a f_sleep(1), but TC_srvcc_eutran_to_geran_ho_out() didn't, making it fail sometimes. Change-Id: I590b09353900dfe6c4f648812ab675fed1908589 --- M bsc/BSC_Tests.ttcn 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 41deea1..074fa60 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -4858,6 +4858,12 @@ BSSAP.send(ts_BSSMAP_ClearCommand(cause)); f_expect_dlcx_conns(); + + interleave { + [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_RR_RELEASE)); + [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)); + [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)); + } setverdict(pass); } @@ -4870,7 +4876,6 @@ f_establish_fully(ass_req, exp_compl); f_ho_out_of_this_bsc(); - f_sleep(1.0); } testcase TC_ho_out_of_this_bsc() runs on test_CT { var MSC_ConnHdlr vc_conn; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I590b09353900dfe6c4f648812ab675fed1908589 Gerrit-Change-Number: 24665 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210615/3cb64b8b/attachment.htm>