Change in osmo-ttcn3-hacks[master]: bsc: implement ttcn API and cfg for A5/4

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 15 13:37:21 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24669 )

Change subject: bsc: implement ttcn API and cfg for A5/4
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24669/1/bsc/MSC_ConnectionHandler.ttcn 
File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24669/1/bsc/MSC_ConnectionHandler.ttcn@548 
PS1, Line 548: 	octetstring	enc_kc128 optional
This is already used in previous commit I think?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24669/1/bsc/MSC_ConnectionHandler.ttcn@732 
PS1, Line 732: 		expect_kc := enc.enc_kc128;
why not using same field regardless of the algo? in the end it's an octetstring.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24669
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifa48a8498dde7d04fb29f497013bdb5a1e5f3597
Gerrit-Change-Number: 24669
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 15 Jun 2021 13:37:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210615/0a1bd54a/attachment.htm>


More information about the gerrit-log mailing list