Change in libosmocore[master]: gprs_ns2_sns: implement outbound SNS ADD procedures

daniel gerrit-no-reply at lists.osmocom.org
Tue Jun 15 12:17:58 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24123 )

Change subject: gprs_ns2_sns: implement outbound SNS ADD procedures
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/24123/7/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/24123/7/src/gb/gprs_ns2_sns.c@1968 
PS7, Line 1968: 			OSMO_ASSERT(gss->role == GPRS_SNS_ROLE_BSS);
Not sure if this really holds true, we should ensure that we don't accidentally abort here.


https://gerrit.osmocom.org/c/libosmocore/+/24123/7/src/gb/gprs_ns2_sns.c@1976 
PS7, Line 1976: (void *) 1
Can we have a #define for this so it's clear what the 1 actually means?
Same in AF_INET6 below



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I71c33200bd1f0307ceb943ee958db5ebe3623d36
Gerrit-Change-Number: 24123
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Tue, 15 Jun 2021 12:17:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210615/35fb25ca/attachment.htm>


More information about the gerrit-log mailing list