Change in osmo-bsc[master]: fixup for vamos: fix wrong cbits in rsl_lchan_lookup()

neels gerrit-no-reply at lists.osmocom.org
Mon Jun 14 22:31:34 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24663 )


Change subject: fixup for vamos: fix wrong cbits in rsl_lchan_lookup()
......................................................................

fixup for vamos: fix wrong cbits in rsl_lchan_lookup()

The RSL_CHAN_OSMO_VAMOS_MASK mask applies to the chan_nr,
but the cbits variable in rsl_lchan_lookup() is chan_nr >> 3.
So the mask didn't do its job. Now it does.

A bit embarrassing how i took the suggestion to use this mask and put it
into code without testing it. It looked good enough...

Change-Id: I005c5f319bb6f14651aeb613cdff52e79f761913
---
M src/osmo-bsc/bts_trx.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/24663/1

diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c
index f183742..edd52be 100644
--- a/src/osmo-bsc/bts_trx.c
+++ b/src/osmo-bsc/bts_trx.c
@@ -170,7 +170,7 @@
 		case ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Bm_ACCHs:
 		case ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Lm_ACCHs(0):
 		case ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Lm_ACCHs(1):
-			cbits &= ~RSL_CHAN_OSMO_VAMOS_MASK;
+			cbits = (chan_nr & ~RSL_CHAN_OSMO_VAMOS_MASK) >> 3;
 			vamos = true;
 			break;
 		default:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24663
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I005c5f319bb6f14651aeb613cdff52e79f761913
Gerrit-Change-Number: 24663
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210614/1d8ad1c6/attachment.htm>


More information about the gerrit-log mailing list