Change in osmo-bsc[master]: handover_ctrl: add control interface for handover settings
gerrit-no-reply at lists.osmocom.org
Mon Jun 14 20:15:03 UTC 2021
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24600 )
Change subject: handover_ctrl: add control interface for handover settings
Patch Set 1:
Thanks for reviewing this.
I have fixed the easy parts. Unfortunately I did not notice the handover commands on network level. I will have another look at this tomorrow.
PS1, Line 41: |handover_ho_active|RW|No|"0","1","default"|Enable/disable handover.
> be aware that (almost?) all handover, handover1 and handover2 vty commands exist on the 'network' no […]
I did not notice that. This probably means that I have dig a bit deeper. I only noticed the handover commands on network level.
PS1, Line 33: bool verify_vty_cmd_arg(void *ctx, const char *range, const char *value)
> i understand: the macros that were invented for VTY are now used for CTRL. […]
The function cmd_match is a bit strange, I could not make it work, but I from the code I can see that it uses cmd_range_match() to match the range. This works fine for me. However, even in cmd_match, I did not see any code that matches the choice strings ("test1|test2|test3").
PS1, Line 88: cmd->reply = talloc_asprintf(cmd, VTY_WRITE_FMT, VTY_WRITE_CONV(val)); \
> the HO_CFG_ONE_MEMBER() has arguments called VTY_WRITE_FMT and VTY_WRITE_CONV. […]
I think putting a comment might sufficient.
PS1, Line 98: if (strcmp(cmd->value, "default") == 0) \
> (before '\' should be space, not tab)
PS1, Line 114: #undef HO_CFG_ONE_MEMBER
> please insert spacing here. […]
PS1, Line 161: rc |= ctrl_cmd_install(CTRL_NODE_ROOT, &cmd_##NAME);\
> (usually no '\' on last line; if you want to keep it maybe add a space before it)
PS1, Line 163: HO_CFG_ALL_MEMBERS
> @pespin i don't understand what you mean […]
Probably we should list the manually defined commands first and then proceed with the auto generated commands.
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24600
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Jun 2021 20:15:03 +0000
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log