Change in libosmocore[master]: gprs_ns2_sns: bss: set gss->family

laforge gerrit-no-reply at lists.osmocom.org
Sun Jun 13 18:31:51 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24590 )

Change subject: gprs_ns2_sns: bss: set gss->family
......................................................................

gprs_ns2_sns: bss: set gss->family

gss->family (and gss->ip) was never set.
So IPv6 should have never worked.

Fixes: e769f5226be6 ("gprs_ns2_sns: rework IP-SNS initial remote")
Related: OS#5036
Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
---
M src/gb/gprs_ns2_sns.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 3f09054..367f77c 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1600,6 +1600,7 @@
 			gss->initial = llist_entry(gss->initial->list.next, struct sns_endpoint, list);
 		}
 
+		gss->family = gss->initial->saddr.u.sa.sa_family;
 		gss->reselection_running = false;
 		osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_BSS_SIZE, nse->nsi->timeout[NS_TOUT_TSNS_PROV], 1);
 		break;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24590
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
Gerrit-Change-Number: 24590
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210613/48e301df/attachment.htm>


More information about the gerrit-log mailing list