Change in pysim[master]: compatibility with cmd2 >= 2.0.0: Don't use 'use_ipython'

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 11 21:39:59 UTC 2021


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24647 )


Change subject: compatibility with cmd2 >= 2.0.0: Don't use 'use_ipython'
......................................................................

compatibility with cmd2 >= 2.0.0: Don't use 'use_ipython'

Upstream cmd2 removed the 'use_ipython' keyword argument.  Three's
a new 'include_ipy' instead.

See https://github.com/python-cmd2/cmd2/commit/2397280cad072a27a51f5ec1cc64908039d14bd1
and https://github.com/python-cmd2/cmd2/issues/1120

To make our life simpler and as a quick fix, we simply disable ipython
support for now.

If this was to be re-introduced, we would have to use
pkg_resources.get_distribution("cmd2") and use packaging.version.parse
to compare against 2.0.0

Change-Id: Ibc9f7a9413b1656dbc1f75e1c3577e8e8db9c03c
---
M pySim-shell.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/47/24647/1

diff --git a/pySim-shell.py b/pySim-shell.py
index 59bfa28..01a1b94 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -56,7 +56,7 @@
 	def __init__(self, card, rs, script = None):
 		basic_commands = [Iso7816Commands(), PySimCommands()]
 		super().__init__(persistent_history_file='~/.pysim_shell_history', allow_cli_args=False,
-				 use_ipython=True, auto_load_commands=False, command_sets=basic_commands, startup_script=script)
+				         auto_load_commands=False, command_sets=basic_commands, startup_script=script)
 		self.intro = style('Welcome to pySim-shell!', fg=fg.red)
 		self.default_category = 'pySim-shell built-in commands'
 		self.card = card

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24647
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibc9f7a9413b1656dbc1f75e1c3577e8e8db9c03c
Gerrit-Change-Number: 24647
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210611/37578942/attachment.htm>


More information about the gerrit-log mailing list