Change in osmo-mgw[master]: mgcp_client: fix error handling in mgcp message generation

dexter gerrit-no-reply at lists.osmocom.org
Fri Jun 11 13:17:10 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24182 )

Change subject: mgcp_client: fix error handling in mgcp message generation
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24182/3/src/libosmo-mgcp-client/mgcp_client.c 
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24182/3/src/libosmo-mgcp-client/mgcp_client.c@1352 
PS3, Line 1352: rc_lco == -2
> you can simply return -ENOBUFS or some other errno value, whcih are guaranteed to be different from  […]
I have fixed now. The code now uses proper return codes. I think it makes also sense to exit early when an error in the data is discovered. Continuing would be pointless. I guess when I wrote this I wanted to have a single location where the error message is printed. Now there are two more, but this also allows to narrow down the problem a bit more - if there is one.

What I find also find problematic (came to my mind while reading Pau's comment). The rc of msgb_printf is currently added up. This is probably not so good since it may then evidently become a different return code if more then one msgb_printf failes. I have fixed that also.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24182
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibb788343e0bec9c0eaf33e6e4727d4d36c100017
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Jun 2021 13:17:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210611/6c7c4d7e/attachment.htm>


More information about the gerrit-log mailing list