Change in osmo-gsm-tester[master]: srs-ms: allows to run given scripts before the execution of the UE.
gerrit-no-reply at lists.osmocom.org
Fri Jun 11 06:52:11 UTC 2021
alealcon has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24277 )
Change subject: srs-ms: allows to run given scripts before the execution of the UE.
Patch Set 2:
For me, this case is the same as the srs-enb pre-init scripts.
I agree with you that the best solution is to add these new features to OGT the way you propose (creating specific classes that add this support/features) and that's what we should do in the future.
Right now we're under heavy development, with a lot of changes and testing, so the idea of the pre/post init script is very good to us, because it allows to run utilities/scripts that will help us to debug the system. I see two big advantages with this: we can do it faster with a script that adding this new feature to OGT and some of this utilities may be temporal and don't make sense to add them to OGT(for example the dmesg before and after the launch of the srs-enb).
My proposal is to add the pre/post run scripts feature to the srs-ms and srs-enb. Then we can list and discuss the feature that each script adds and decide whether to add it to OGT or not (sometimes may be not needed because it's temporal, sometimes won't be worth it, because it's too unstable to add it and most of the times we will add them)
Does it sound good to you?
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: alealcon <alejandro.leal at srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-CC: srs_andre <andre at softwareradiosystems.com>
Gerrit-Comment-Date: Fri, 11 Jun 2021 06:52:11 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log