Change in libosmocore[master]: msgb_alloc_headroom: Change size args to be uint16_t

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 10 15:23:58 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24641 )

Change subject: msgb_alloc_headroom: Change size args to be uint16_t
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24641/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/24641/2//COMMIT_MSG@10 
PS2, Line 10: until now passing a value > 2^16 would succeed providing a msgb with
> probably >= 2^16 […]
You are not hiding the problem to the application/user. Rather if the user looks at the documentation it finds out needs to pass a uint16_t, and hence can't pass values bigger than 2^16.
Believe me, I run into this a few minutes ago while doing some tests ;)



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24641
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I83c8222484e4856c68134a1a9d8cf96eb91af1b8
Gerrit-Change-Number: 24641
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 15:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/a4c256d2/attachment.htm>


More information about the gerrit-log mailing list