Change in libosmocore[master]: ctrl: Support recovering from short write

neels gerrit-no-reply at lists.osmocom.org
Thu Jun 10 14:53:09 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24640 )

Change subject: ctrl: Support recovering from short write
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24640/1/src/ctrl/control_if.c 
File src/ctrl/control_if.c:

https://gerrit.osmocom.org/c/libosmocore/+/24640/1/src/ctrl/control_if.c@494 
PS1, Line 494: return 0;
> Are you sure about returning 0 here?
I guess it should be

  if (rc <= 0)

because writing zero bytes would also mean a failure to write, and -EAGAIN could theoretically end up infinitely retrying



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24640
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6cbc7ec6ae6832e61cddf4402332ba09b142a7d4
Gerrit-Change-Number: 24640
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 14:53:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/a5ddf138/attachment.htm>


More information about the gerrit-log mailing list