Change in libosmocore[master]: make use of OTC_GLOBAL when allocating library-internal contexts

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 10 14:36:09 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13338 )

Change subject: make use of OTC_GLOBAL when allocating library-internal contexts
......................................................................


Patch Set 23:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/gsm/lapd_core.c 
File src/gsm/lapd_core.c:

https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/gsm/lapd_core.c@257 
PS23, Line 257: __thread void *tall_lapd_ctx;
> I'd say adding __thread here is actually a different fix/commit.
Ack


https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/gsm/lapdm.c 
File src/gsm/lapdm.c:

https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/gsm/lapdm.c@129 
PS23, Line 129: extern __thread void *tall_lapd_ctx;
> same (__thread)
Ack


https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/signal.c 
File src/signal.c:

https://gerrit.osmocom.org/c/libosmocore/+/13338/23/src/signal.c@42 
PS23, Line 42: static void *tall_sigh_ctx2;
> why not reuse the tall_sigh_ctx and make it static once we get rid of its use in openbsc?
because we always  want to be abl to build old applications against new libosmocore libraries.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13338
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I48f475efd3ee0d5120b8fc30861e852d1a6920b1
Gerrit-Change-Number: 13338
Gerrit-PatchSet: 23
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 14:36:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/dd31b7bc/attachment.htm>


More information about the gerrit-log mailing list