Change in osmo-ttcn3-hacks[master]: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 10 12:50:03 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401 )

Change subject: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

fine with me, really just the minor question if we need a separate function for setting an argument to null.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401/4/library/NS_Provider_IPL4.ttcn 
File library/NS_Provider_IPL4.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401/4/library/NS_Provider_IPL4.ttcn@219 
PS4, Line 219: f_nspip_add_nsvc2
I'm a bit surprised we need this extra function. Is it not legal to pass "null" as vc_nsvc argument to  f_nsip_add_nsvc() ?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iafd9310e04066958914201da0cbdcd563bd5c976
Gerrit-Change-Number: 24401
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 10 Jun 2021 12:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/434894cf/attachment.htm>


More information about the gerrit-log mailing list