This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24613 ) Change subject: osmo-bts-trx: report interference levels to the upper layers ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/24613/1/include/osmo-bts/scheduler.h File include/osmo-bts/scheduler.h: https://gerrit.osmocom.org/c/osmo-bts/+/24613/1/include/osmo-bts/scheduler.h@138 PS1, Line 138: struct l1sched_meas_set buf[8]; /* up to 8 entries */ > unless that magic number is repeated later in the code (I didn't see that) it is ok. […] This buffer was here before and not related to this change at all. I just moved the comments, because I am adding more fields to this structure. Anyway, it's 8 because the scheduler can buffer up to 8 bursts (TCH/F). Once we introduce CSD, where the bits can be distributed over 22 (!) bursts, we will increase this number. https://gerrit.osmocom.org/c/osmo-bts/+/24613/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/24613/1/src/common/scheduler.c@1494 PS1, Line 1494: if (bi->chan >= TRXC_TCHF) > Doing the comparison with a >= sounds a bit dangerous since it relies on the order of the items in t […] I'll introduce a macro in the new patchset, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4686448e42a40df56c1d27a14fd0a4d43fd144a5 Gerrit-Change-Number: 24613 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jun 2021 12:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: dexter <pmaier at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/5585fefb/attachment.htm>