Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 10 12:33:21 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24374 )

Change subject: implement Channel Mode Modify to VAMOS mode
......................................................................


Patch Set 20:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/20/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24374/20/src/osmo-bsc/abis_rsl.c@506 
PS20, Line 506: struct rsl_osmo_training_sequence_ie {
> that's the weird thing about our RSL implementation: we have the protocol TLV list and IE defines an […]
To stay consisten with the existing code base, the truct definition should be in include/osmocom/gsm/protocol/gsm_08_58.h.  Thisis just the struct definition and not about encoder/decoder functions.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c
Gerrit-Change-Number: 24374
Gerrit-PatchSet: 20
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 12:33:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/29909331/attachment.htm>


More information about the gerrit-log mailing list