Change in osmo-sgsn[master]: add support for multiple encryption algorithms and a5/4

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 10 12:24:55 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/24304 )

Change subject: add support for multiple encryption algorithms and a5/4
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/2/src/sgsn/sgsn_vty.c 
File src/sgsn/sgsn_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/24304/2/src/sgsn/sgsn_vty.c@732 
PS2, Line 732: (GEA0-4) [GEA0-4] [GEA0-4] [GEA0-4] [GEA0-4]
> The whole point here was to stay compatible with the existing syntax and not introduce a legacy comm […]
I think even the existing command is broken in the sense  that the upper-case tokens will not be "tokens"and hence tab completion doesn't work.
The tokens should always have been lower-case.

But as we are changing this anyway, I would suggest to do it properly now, and keep some backwards legacy compat command to load old configs.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/24304
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie6700c4e9d2df1eb5fde1b971e287b62668cc2de
Gerrit-Change-Number: 24304
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 12:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/70bbcf98/attachment.htm>


More information about the gerrit-log mailing list