Change in osmo-bts[master]: common/vty: facilitate finding duplicate PHY/TRX associations

fixeria gerrit-no-reply at lists.osmocom.org
Thu Jun 10 11:53:06 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24289 )

Change subject: common/vty: facilitate finding duplicate PHY/TRX associations
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

1+1

https://gerrit.osmocom.org/c/osmo-bts/+/24289/2/src/common/phy_link.c 
File src/common/phy_link.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24289/2/src/common/phy_link.c@121 
PS2, Line 121: 	/* There might already be an associated TRX */
> maybe add some comment about the fact that the VTY will not call this function when a trx is already […]
Well, assert() itself implies that nobody should call this function when pinst is already associated with a trx instance...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24289
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I132e08fc496abef278b94254cebfac7a4285a7c2
Gerrit-Change-Number: 24289
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 11:53:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/e6c11d5d/attachment.htm>


More information about the gerrit-log mailing list