Change in libosmocore[master]: utils: introduce osmo_talloc_replace_string_fmt()

dexter gerrit-no-reply at lists.osmocom.org
Thu Jun 10 10:15:50 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24598 )

Change subject: utils: introduce osmo_talloc_replace_string_fmt()
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

looks ok to me but a docstring should be added because if it is missing the function would not appear in the apidoc? I don't know I never looked at the generated apidoc.

https://gerrit.osmocom.org/c/libosmocore/+/24598/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/24598/1//COMMIT_MSG@7 
PS1, Line 7: utils: introduce osmo_talloc_replace_string_fmt()
maybe dropping a line about what osmo_talloc_replace_string_fmt() is useful for would be good. At the moment I do not get what's the advantage over using talloc_vsprintf() directly.


https://gerrit.osmocom.org/c/libosmocore/+/24598/1/include/osmocom/core/utils.h 
File include/osmocom/core/utils.h:

https://gerrit.osmocom.org/c/libosmocore/+/24598/1/include/osmocom/core/utils.h@119 
PS1, Line 119: 
a docstring might be helpful, even if it is just for completeness.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6b84fa0525555a98c531fc558e5dc1298fec00c1
Gerrit-Change-Number: 24598
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 10:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/696882e1/attachment.htm>


More information about the gerrit-log mailing list