Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode

neels gerrit-no-reply at
Wed Jun 9 15:00:35 UTC 2021

neels has posted comments on this change. ( )

Change subject: implement Channel Mode Modify to VAMOS mode

Patch Set 20:

(1 comment) 
File src/osmo-bsc/abis_rsl.c: 
PS20, Line 506: struct rsl_osmo_training_sequence_ie {
> Looks like this belongs to libosmogsm or libosmoabis, because somo-bts also requires it.
that's the weird thing about our RSL implementation: we have the protocol TLV list and IE defines and so on in libosmocore, but every program implements its own message encoding and decoding functions all over.
So I agree that this encoding and decoding of the IE should have lived in libosmocore, sort of like we do with the BSSAP messaging, but so far it kind of belongs here instead.

So now I asked Vadim whether he's going to use this struct in osmo-bts source, but he says no.
Since it's only two octets he rather reads them directly from the data.
That would have been a reason to move to libosmocore.

(I could also just msg_put_u8() twice here...)

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c
Gerrit-Change-Number: 24374
Gerrit-PatchSet: 20
Gerrit-Owner: neels <nhofmeyr at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at>
Gerrit-Reviewer: fixeria <vyanitskiy at>
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-Comment-Date: Wed, 09 Jun 2021 15:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list