Change in osmo-bts[master]: conf_lchans_as_pchan(): initialize all lchans with GSM_LCHAN_NONE

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 9 13:34:31 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24604 )

Change subject: conf_lchans_as_pchan(): initialize all lchans with GSM_LCHAN_NONE
......................................................................

conf_lchans_as_pchan(): initialize all lchans with GSM_LCHAN_NONE

This function is called during the OML bootstrapping, and also
when a dynamic timeslot switches between PDCH and TCH/{F,H}.
In the later case, after switching from TCH/{F,H} to PDCH, some
lchans might still have the old type assigned.

Let's ensure that all logical channels are properly updated.

Change-Id: I44726f2bfb979c2fa2f5f30c5b11700cf4b3399d
Related: SYS#5313, OS#1569
---
M src/common/oml.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/oml.c b/src/common/oml.c
index 6acc6b1..8b84f85 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -826,6 +826,9 @@
 int conf_lchans_as_pchan(struct gsm_bts_trx_ts *ts,
 			 enum gsm_phys_chan_config pchan)
 {
+	/* Initialize all lchans with GSM_LCHAN_NONE first */
+	lchans_type_set(ts, GSM_LCHAN_NONE, ARRAY_SIZE(ts->lchan));
+
 	switch (pchan) {
 	case GSM_PCHAN_CCCH_SDCCH4_CBCH:
 	case GSM_PCHAN_CCCH_SDCCH4:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24604
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I44726f2bfb979c2fa2f5f30c5b11700cf4b3399d
Gerrit-Change-Number: 24604
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210609/3f26b641/attachment.htm>


More information about the gerrit-log mailing list