Change in osmo-ttcn3-hacks[master]: sgsn a54 tests

dexter gerrit-no-reply at lists.osmocom.org
Wed Jun 9 10:18:46 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24629 )

Change subject: sgsn a54 tests
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24629/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24629/1//COMMIT_MSG@7 
PS1, Line 7: sgsn a54 tests
may be it makes sense to drop a line or two on what the test case does.

As I read it it just sends an attach request and then it waits for the SGSN to do the authentication request, which is answered by the testcase.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24629/1/sgsn/SGSN_Tests.ttcn 
File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24629/1/sgsn/SGSN_Tests.ttcn@2878 
PS1, Line 2878: 	BSSGP[0].receive(auth_ciph_req) -> value l3_mt;
I think the -> value l3_mt; can be dropped. The testcase is done until here, no need to store the response in a variable.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24629
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iad65cbf9840aa883cb34e53554b94a4142c82638
Gerrit-Change-Number: 24629
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Jun 2021 10:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210609/ae5f3832/attachment.htm>


More information about the gerrit-log mailing list