Change in osmo-bsc[master]: [WIP] a5/4 support

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jun 9 08:42:25 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24635 )

Change subject: [WIP] a5/4 support
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24635/2/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/24635/2/include/osmocom/bsc/gsm_data.h@237 
PS2, Line 237:     uint8_t kc128[16];
coding style


https://gerrit.osmocom.org/c/osmo-bsc/+/24635/2/src/osmo-bsc/handover_fsm.c 
File src/osmo-bsc/handover_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24635/2/src/osmo-bsc/handover_fsm.c@490 
PS2, Line 490: 	for( i= 0; i < req->ei.perm_algo_len; i++) {
coding style


https://gerrit.osmocom.org/c/osmo-bsc/+/24635/2/src/osmo-bsc/handover_fsm.c@497 
PS2, Line 497: 	if (has_a54) {
something is definitely wrong with formatting here


https://gerrit.osmocom.org/c/osmo-bsc/+/24635/2/src/osmo-bsc/osmo_bsc_bssap.c 
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24635/2/src/osmo-bsc/osmo_bsc_bssap.c@546 
PS2, Line 546:     /* kc128 mandatory for a5/4 */
coding style


https://gerrit.osmocom.org/c/osmo-bsc/+/24635/2/src/osmo-bsc/osmo_bsc_bssap.c@564 
PS2, Line 564: 	if(chosen_cipher == 4) {
coding style: if is not a function



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24635
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7c458c8a7350f34ff79531b3c891e1b367614469
Gerrit-Change-Number: 24635
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Jun 2021 08:42:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210609/3b025c13/attachment.htm>


More information about the gerrit-log mailing list