Change in osmo-bsc[master]: cosmetic prep: hodec2: move is_upgrade_to_tchf() further up

neels gerrit-no-reply at lists.osmocom.org
Tue Jun 8 22:12:12 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24605 )

Change subject: cosmetic prep: hodec2: move is_upgrade_to_tchf() further up
......................................................................

cosmetic prep: hodec2: move is_upgrade_to_tchf() further up

Preparation for Id40d1cf8b58410c7d4eb87407fe8b8106e352438

Related: SYS#5198 SYS#5365
Change-Id: I3fd0e257e033c573017ce62e3efc19b094acf73c
---
M src/osmo-bsc/handover_decision_2.c
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  dexter: Looks good to me, approved



diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c
index b2027d9..3e86a92 100644
--- a/src/osmo-bsc/handover_decision_2.c
+++ b/src/osmo-bsc/handover_decision_2.c
@@ -167,6 +167,13 @@
 
 static void congestion_check_cb(void *arg);
 
+static bool is_upgrade_to_tchf(const struct ho_candidate *c, uint8_t for_requirement)
+{
+	return c->current.lchan
+		&& (c->current.lchan->type == GSM_LCHAN_TCH_H)
+		&& ((c->requirements & for_requirement) & (REQUIREMENT_B_TCHF | REQUIREMENT_C_TCHF));
+}
+
 static unsigned int ts_usage_count(struct gsm_bts_trx_ts *ts)
 {
 	struct gsm_lchan *lchan;
@@ -1535,13 +1542,6 @@
 		|| lchan->ts->pchan_on_init == GSM_PCHAN_TCH_F_PDCH;
 }
 
-static bool is_upgrade_to_tchf(const struct ho_candidate *c, uint8_t for_requirement)
-{
-	return c->current.lchan
-		&& (c->current.lchan->type == GSM_LCHAN_TCH_H)
-		&& ((c->requirements & for_requirement) & (REQUIREMENT_B_TCHF | REQUIREMENT_C_TCHF));
-}
-
 /* Given two candidates, pick the one that should rather be moved during handover.
  * Return the better candidate in out-parameters best_cand and best_avg_db.
  */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24605
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3fd0e257e033c573017ce62e3efc19b094acf73c
Gerrit-Change-Number: 24605
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210608/ef4f0284/attachment.htm>


More information about the gerrit-log mailing list