Change in osmo-bts[master]: l1sap: fix TDMA frame number arithmetic in fn_ms_adj()

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jun 8 12:27:23 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24601 )

Change subject: l1sap: fix TDMA frame number arithmetic in fn_ms_adj()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/24601/1/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24601/1/src/common/l1sap.c@142 
PS1, Line 142: 		samples_passed = GSM_TDMA_FN_SUB(fn, lchan->tch.last_fn);
> splitting it into 2 assignments is imho confusing, since in this line you store a FN into a function […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie17670d150489014a4a2e140cede42086100bbc0
Gerrit-Change-Number: 24601
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Jun 2021 12:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210608/28f539cd/attachment.htm>


More information about the gerrit-log mailing list