Change in osmo-mgw[master]: mgcp_client: do not crash when lco/sdp can not be generated

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 8 11:42:01 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24182 )

Change subject: mgcp_client: do not crash when lco/sdp can not be generated
......................................................................


Patch Set 3: -Code-Review

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24182/3/src/libosmo-mgcp-client/mgcp_client.c 
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/24182/3/src/libosmo-mgcp-client/mgcp_client.c@1352 
PS3, Line 1352: rc_lco == -2
> Yes, it indicates a problem with the input data (aborted, msgb freed). […]
You cannot guarantee EINVAL is different that a given negative value, since errno numbers can change per platform IIRC. So I'd better return a different errno rather than a fixed value. It would also be more descriptive.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24182
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibb788343e0bec9c0eaf33e6e4727d4d36c100017
Gerrit-Change-Number: 24182
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Jun 2021 11:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210608/3d63c3a2/attachment.htm>


More information about the gerrit-log mailing list