Change in osmo-bsc[master]: handover_ctrl: add control interface for handover settings

pespin gerrit-no-reply at lists.osmocom.org
Tue Jun 8 08:19:58 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24600 )

Change subject: handover_ctrl: add control interface for handover settings
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c 
File src/osmo-bsc/handover_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@33 
PS1, Line 33: bool verify_vty_cmd_arg(void *ctx, const char *range, const char *value)
that's not used for vty here right? I guess it can be static.


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@88 
PS1, Line 88: 		cmd->reply = talloc_asprintf(cmd, VTY_WRITE_FMT, VTY_WRITE_CONV(val)); \
why are we using VTY stuff here? Are these fmts safe for ctrl interface?
Where are VTY_WRITE_FMT and VTY_WRITE_CONV declared? I cannot find them.


https://gerrit.osmocom.org/c/osmo-bsc/+/24600/1/src/osmo-bsc/handover_ctrl.c@163 
PS1, Line 163: HO_CFG_ALL_MEMBERS
For improved readability it may make sense to move HO_CFG_ALL_MEMBERS at the end of the list here. Same with functions/defines above.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24600
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12f143906818fd6b16e8783157cbb1eb51e49ffc
Gerrit-Change-Number: 24600
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 08 Jun 2021 08:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210608/2ce16f76/attachment.htm>


More information about the gerrit-log mailing list