Change in osmo-bsc[master]: RSL: rx and tx VAMOS Channel Number cbits for VAMOS lchans

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jun 7 20:00:07 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24430 )

Change subject: RSL: rx and tx VAMOS Channel Number cbits for VAMOS lchans
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24430/15/src/osmo-bsc/bts_trx.c 
File src/osmo-bsc/bts_trx.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24430/15/src/osmo-bsc/bts_trx.c@167 
PS15, Line 167: 		switch (cbits) {
You could use RSL_CHAN_OSMO_VAMOS_MASK here:

  switch (cbits) {
  case ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Bm_ACCHs:
  case ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Lm_ACCHs(0):
  case ABIS_RSL_CHAN_NR_CBITS_OSMO_VAMOS_Lm_ACCHs(1):
    cbits &= ~RSL_CHAN_OSMO_VAMOS_MASK;
    vamos = true;
    break;
  }

or even simpler (you may not like this solution):
  if (cbits & RSL_CHAN_OSMO_VAMOS_MASK) {
    cbits &= ~RSL_CHAN_OSMO_VAMOS_MASK;
    vamos = true;
  }



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I957eff0d2c33ec795eda75a4bff21965b0179f73
Gerrit-Change-Number: 24430
Gerrit-PatchSet: 15
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 07 Jun 2021 20:00:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210607/c776614b/attachment.htm>


More information about the gerrit-log mailing list