Change in libosmocore[master]: utils: introduce osmo_talloc_replace_string_fmt()

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jun 7 15:01:34 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24598 )

Change subject: utils: introduce osmo_talloc_replace_string_fmt()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24598/1/include/osmocom/core/utils.h 
File include/osmocom/core/utils.h:

https://gerrit.osmocom.org/c/libosmocore/+/24598/1/include/osmocom/core/utils.h@120 
PS1, Line 120: static inline void osmo_talloc_replace_string_fmt(void *ctx, char **dst,
> Not sure whether having all this chunk with variable params as a static inline is a good idea. […]
What's wrong with having it here?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6b84fa0525555a98c531fc558e5dc1298fec00c1
Gerrit-Change-Number: 24598
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Jun 2021 15:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210607/c008b0b8/attachment.htm>


More information about the gerrit-log mailing list