Change in libosmocore[master]: gprs_ns2_sns: add check for duplicates to add_ip6_elem()

laforge gerrit-no-reply at lists.osmocom.org
Mon Jun 7 12:39:43 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24586 )

Change subject: gprs_ns2_sns: add check for duplicates to add_ip6_elem()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24586/1/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/24586/1/src/gb/gprs_ns2_sns.c@510 
PS1, Line 510: 		if (memcmp(&elems->ip6[i], ip6, sizeof(*ip6)))
I'm not sure we should rely on the fact that there is either no padding in the elems struct, or that it is always zero-initialized.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24586
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4a1528ea3427946ce465085919b2b522d3cedd07
Gerrit-Change-Number: 24586
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 07 Jun 2021 12:39:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210607/6950de79/attachment.htm>


More information about the gerrit-log mailing list