Change in osmo-bsc[master]: src/utils/meas_vis.c: fix bs_power -> bs_power_db

laforge gerrit-no-reply at lists.osmocom.org
Mon Jun 7 08:14:07 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24595 )

Change subject: src/utils/meas_vis.c: fix bs_power -> bs_power_db
......................................................................

src/utils/meas_vis.c: fix bs_power -> bs_power_db

Fix build error:
  meas_vis.c:196:16: error: 'struct gsm_meas_rep' has no member named 'bs_power'; did you mean 'bs_power_db'?

Output the value in the same format as before the change that introduced
this regression (dB / 2).

We didn't catch this regression with jenkins because meas_vis is only
built if libcdk is installed.

Related: OS#5173
Fixes: d9b7aedb ("change bs_power to bs_power_db")
Change-Id: I9ba9b491ccbde9aa14cfb14ecc551acb2bfd7674
---
M src/utils/meas_vis.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/utils/meas_vis.c b/src/utils/meas_vis.c
index 73ccfc4..c3ee2a5 100644
--- a/src/utils/meas_vis.c
+++ b/src/utils/meas_vis.c
@@ -193,7 +193,7 @@
 	if (dir == DIR_UL) {
 		pwr = ms->mr.ms_l1.pwr;
 	} else {
-		pwr = ms->mr.bs_power;
+		pwr = ms->mr.bs_power_db / 2;
 	}
 
 	color = A_REVERSE | COLOR_PAIR(lev_col) | ' ';

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24595
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9ba9b491ccbde9aa14cfb14ecc551acb2bfd7674
Gerrit-Change-Number: 24595
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210607/69b4c6f1/attachment.htm>


More information about the gerrit-log mailing list