Change in simtrace2[master]: firmware: octsimtest: ensure all card_insert GPIO are 0 after reset

laforge gerrit-no-reply at lists.osmocom.org
Sun Jun 6 10:22:02 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/24573 )

Change subject: firmware: octsimtest: ensure all card_insert GPIO are 0 after reset
......................................................................

firmware: octsimtest: ensure all card_insert GPIO are 0 after reset

Change-Id: I3c3744673ba53750cb66aa5023c8228edb006bfc
---
M firmware/libboard/octsimtest/source/board_octsimtest.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c b/firmware/libboard/octsimtest/source/board_octsimtest.c
index c77c1ce..d8b1cc4 100644
--- a/firmware/libboard/octsimtest/source/board_octsimtest.c
+++ b/firmware/libboard/octsimtest/source/board_octsimtest.c
@@ -79,8 +79,10 @@
 	mux_init();
 	i2c_pin_init();
 	/* PORT A: all outputs, Port B0 output, B1..B7 unused */
-	if (mcp23017_init(MCP23017_ADDRESS, 0x00, 0xfe) == 0)
+	if (mcp23017_init(MCP23017_ADDRESS, 0x00, 0xfe) == 0) {
 		mcp2317_present = true;
+		mcp23017_set_output_a(MCP23017_ADDRESS, 0);
+	}
 	/* Initialize checking for card insert/remove events */
 	//card_present_init();
 #endif

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/24573
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I3c3744673ba53750cb66aa5023c8228edb006bfc
Gerrit-Change-Number: 24573
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210606/2e9f5d76/attachment.htm>


More information about the gerrit-log mailing list