Change in osmo-bsc[master]: lchan_fsm: introduce lchan.activate.ch_mode_rate to allow tweaking

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jun 6 01:37:50 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24458 )

Change subject: lchan_fsm: introduce lchan.activate.ch_mode_rate to allow tweaking
......................................................................


Patch Set 8: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24458/8/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/24458/8/include/osmocom/bsc/gsm_data.h@648 
PS8, Line 648: 		struct channel_mode_and_rate ch_mode_rate;
It would be good to clarify it here (in a comment) why do we habe another 'ch_mode_rate' outside of the 'info' and which one is supposed to be immutable.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24458
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icc9cc7481b3984fdca34eef49ea91ad3388c06fe
Gerrit-Change-Number: 24458
Gerrit-PatchSet: 8
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 06 Jun 2021 01:37:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210606/9dfd52de/attachment.htm>


More information about the gerrit-log mailing list