Change in osmo-bts[master]: [VAMOS] scheduler: drop meaningless channel number checks

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jun 5 13:00:32 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24486 )

Change subject: [VAMOS] scheduler: drop meaningless channel number checks
......................................................................

[VAMOS] scheduler: drop meaningless channel number checks

Change-Id: Icc57e58feece51c2d1c421454352bc821e338973
---
M src/common/scheduler.c
1 file changed, 0 insertions(+), 10 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 75cf6bd..6472e89 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -874,11 +874,6 @@
 	chan_nr = trx_chan_desc[br->chan].chan_nr | br->tn;
 	link_id = trx_chan_desc[br->chan].link_id;
 
-	if (!chan_nr) {
-		LOGL1SB(DL1P, LOGL_FATAL, l1ts, br, "RTS func with non-existing chan_nr 0x%02x\n", chan_nr);
-		return -ENODEV;
-	}
-
 	/* For handover detection, there are cases where the SACCH should remain inactive until the first RACH
 	 * indicating the TA is received. */
 	if (L1SAP_IS_LINK_SACCH(link_id)
@@ -914,11 +909,6 @@
 	chan_nr = trx_chan_desc[br->chan].chan_nr | br->tn;
 	link_id = trx_chan_desc[br->chan].link_id;
 
-	if (!chan_nr) {
-		LOGL1SB(DL1P, LOGL_FATAL, l1ts, br, "RTS func with non-existing chan_nr 0x%02x\n", chan_nr);
-		return -ENODEV;
-	}
-
 	LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "TCH RTS.ind: chan_nr=0x%02x\n", chan_nr);
 
 	/* only send, if FACCH is selected */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24486
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icc57e58feece51c2d1c421454352bc821e338973
Gerrit-Change-Number: 24486
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210605/f8b1c9fb/attachment.htm>


More information about the gerrit-log mailing list